[m-rev.] for post-commit review: report unqualified types in .int files

Julien Fischer jfischer at opturion.com
Sat Oct 10 20:55:10 AEDT 2020


On Sat, 10 Oct 2020, Zoltan Somogyi wrote:

> 2020-10-10 18:45 GMT+11:00 "Dirk Ziegemeyer" <dirk at ziegemeyer.de>:
>> thank you for fixing the error message.
>
> You are welcome.
> 
>> mercury_memory_handlers.c:64:6: error: "MR_HAVE_SIGINFO defined but don't know how to get it"
>>     #error "MR_HAVE_SIGINFO defined but don't know how to get it"
>>      ^
>> mercury_memory_handlers.c:83:6: error: "MR_HAVE_SIGINFO defined but don't know how to get it"
>>     #error "MR_HAVE_SIGINFO defined but don't know how to get it"
>>      ^
>> mercury_memory_handlers.c:270:41: error: use of undeclared identifier 'bus_handler'
>>     MR_setup_signal(SIGBUS, (MR_Code *) bus_handler, MR_TRUE,
>>                                         ^
>> mercury_memory_handlers.c:273:42: error: use of undeclared identifier 'segv_handler'
>>     MR_setup_signal(SIGSEGV, (MR_Code *) segv_handler, MR_TRUE,
>
> It seems that mercury_memory_handlers.c expects MR_HAVE_SIGINFO to be set
> in a small set of circumstances, as indicated by the #ifs nested inside #ifdef MR_HAVE_SIGINFO,
> but configure.ac sets MR_HAVE_SIGINFO in more circumstances than that. It looks like
> mercury_memory_handlers.c was not updated when configure.ac was.
>
> Peter, you wrote most of the configure.ac lines that mention MR_HAVE_SIGINFO,
> and you also touched them most recently, so could you please have a look at this?
>
>> Is this any known issue?
>
> Not by me.

Nor by me; I've just tried on installing the same ROTD on Mojave and
that works fine, so I suspect something has changed in Catalina.

Julien.


More information about the reviews mailing list