[m-rev.] for review: simplify the use of mdbrc by test cases

Julien Fischer jfischer at opturion.com
Sun Oct 4 22:58:53 AEDT 2020


On Sun, 4 Oct 2020, Zoltan Somogyi wrote:

> For review by anyone.

> ZZZ

Delete ZZZ.

> Simplify the setup of mdbrc for tests.
> 
> We used to set up *two* mdbrc files for use by test cases:
> scripts/test_mdbrc, and tests/mdbrc. Tools/bootcheck said
> the tests should use the former, while tests/Mmake.common
> said they should use the latter. This diff deletes the latter,
> and uniformly uses the former.
> 
> The setup code was also scattered, with parts being done by
> the configure script, and part being done by tools/bootcheck.
> Move it all to scripts/Mmakefile, since that is the natural
> place to put code to build scripts/test_mdbrc.
> 
...

> diff --git a/tests/Mmakefile b/tests/Mmakefile
> index 18c76bd..5e3a614 100644
> --- a/tests/Mmakefile
> +++ b/tests/Mmakefile
> @@ -5,6 +5,7 @@
>  THIS_DIR=tests
>  PROGS=
>  TESTS=
> +# MERCURY_DIR=..

Why has the commented out line above been added?

>  # If you modify this, modify all_test_dirs in tools/bootcheck as well.
>  SUBDIRS = \

That looks fine otherwise.

Julien.


More information about the reviews mailing list