[m-rev.] for possible review: use explicit streams in the MLDS backend
zoltan.somogyi at runbox.com
Tue Nov 17 11:20:21 AEDT 2020
2020-11-16 23:40 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> It has bootchecked in hlc.gc, csharp and java grades. In the last two
>> grades, it had a few more test failures than the last bootchecks I did
>> in those grades, but I haven't seen any evidence that they were caused
>> by this change.
> If it was the string format tests, I committed a fix for them yesterday.
No, it wasn't. The diff between the lists of failed tests from several days
ago and with the diff is attached.
However, I have now done another bootcheck in java grade in another
workspace, and the only differences in the stage 2 .java files between
that bootcheck and the bootcheck of this diff are in the modules whose
source code this diff changes, so I am pretty sure this diff did not cause
the extra failures.
> The diff looks fine.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 990 bytes
Desc: not available
More information about the reviews