[m-rev.] for review: rewrite rest of options_file.m

Julien Fischer jfischer at opturion.com
Fri Jun 12 23:26:28 AEST 2020

On Fri, 12 Jun 2020, Zoltan Somogyi wrote:

> 2020-06-09 10:33 GMT+10:00 Julien Fischer<jfischer at opturion.com>:
>>>>> I couldn't find any. I do think there should be some, but I am not sure
>>>>> whether these should go in e.g. tests/hard_coded, or in a new subdirectory
>>>>> of tests dedicated to tests of option file handling.
>>>> It should be a new subdirectory; there's enough complication in
>>>> hard_coded as it is.
>>> Agreed. However, we will need tests for both (a) correct options files,
>>> and (b) incorrect options files. I think these belong in two separate
>>> directories. Does anyone object to naming these "options_file"
>>> and "invalid_options_file" respectively?
>> Not from me.
> The attached updated log and diff extend the ones in my
> original email to add both of these new test directories.
> You may want to have a look at the new parts.

Done; they look fine.


More information about the reviews mailing list