[m-rev.] for review: rewrite rest of options_file.m
jfischer at opturion.com
Thu Jun 11 01:35:29 AEST 2020
On Wed, 10 Jun 2020, Zoltan Somogyi wrote:
> 2020-06-09 10:33 GMT+10:00 Julien Fischer<jfischer at opturion.com>:
>> I think the commit that broke it was either afe2887 or 520ce39 since
>> they are the ones that changed the value of TEST_DIRS to hardcode it
>> to '..'.
>> The problem being that when you now do "mmake runtests" in the tests
>> directory itself, it looks for various files in the top-level of
>> the the source tree, rather than in the tests directory itself,
>> Mmake.common:82: ../DEFNS_FOR_TESTS: No such file or directory mercury_compile:
>> cannot open ../TESTS_FLAGS: can't open input file: No such file or directory
>> mercury_compile: cannot open ../TESTS_FLAGS: can't open input file: No such file or directory
>> gmake: *** No rule to make target `../DEFNS_FOR_TESTS'. Stop.
> The attached diff fixes this problem, at least for me.
And for me too.
> Can you please have a look at it post-commit?
Looks fine -- thanks for that.
More information about the reviews