[m-rev.] for post-commit review: put foreign_codes before foreign_procs in LLDS

Peter Wang novalazy at gmail.com
Wed Jul 29 12:36:08 AEST 2020


On Sun, 26 Jul 2020 21:52:26 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> This should fix Keri Harris's problem. For review by anyone.
> 
> Zoltan.

> Put foreign_codes before foreign_procs for LLDS.
> 
> This fixes a bug reported by Keri Harris on m-users.
> 
> compiler/llds_out_file.m:
>     Output foreign_codes before the C modules that may contain
>     foreign_procs, since those foreign_procs may need to refer
>     to entities defined in the foreign_codes.

That looks fine. I must have hit that many times over the years,
and simply assumed the order was unspecified in the manual.

Peter


More information about the reviews mailing list