[m-rev.] for pre-commit review: workaround Mantis bug #453

Julien Fischer jfischer at opturion.com
Mon Jan 20 15:42:38 AEDT 2020



On Mon, 20 Jan 2020, Peter Wang wrote:

> On Mon, 20 Jan 2020 13:33:45 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>>>
>>> Ok.
>>>
>>> I think instead of your original patch, we should be setting
>>>    mercury_cv_asm_labels=no
>>>    mercury_cv_gcc_labels=no
>>>
>>> as in the attached patch.
>>
>> Yes, that's a better approach.  Can you please go ahead and commit
>> that one.
>
> Done.

Thanks.

> I thought of another workaround that might work: to use non-PIC in
> shared libraries. But I won't be pursuing it.

i*86 isn't that important of a platform any more that it warrents
spending more time on it.  For non-debugging, non-deep profiling
programs users are better off with hlc.gc; it's faster anyway.

Julien.


More information about the reviews mailing list