[m-rev.] for pre-commit review: workaround Mantis bug #453

Julien Fischer jfischer at opturion.com
Sun Jan 19 20:22:20 AEDT 2020


On Sun, 19 Jan 2020, Peter Wang wrote:

> On Sun, 19 Jan 2020 18:12:02 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>>
>> For pre-commit review by Peter.
>>
>> In particular:
>>
>> - should we instead handle this by forcing the use of gcc -O0 in asm_fast
>> grades on affected systes?
>
> Only in PIC mode.

So, force gcc -O0 in PIC mode only as opposed to this diff?

> We might want to disable the combination of gcc + asm_fast + x86 + PIC,

If you mean not install the PIC version of the libraries in asm_fast
only, that's going to be complicated to arrange. I think just not
allowing asm_fast in that case (as in the diff) is preferable.

> or silently make asm_fast work like reg in that case.

I'm not sure what you mean by the latter.

>> - are there other systems that this workaround needs to be applied to?
>
> AIUI the problem should not be specific to Linux, but I haven't checked
> on any other OS yet.

Neither have I; I am assuming it is an issue for any i*86 system that
uses ELF executables.

Julien.


More information about the reviews mailing list