[m-rev.] for review: announce the fix for bug #496

Julien Fischer jfischer at opturion.com
Sun Feb 9 18:09:43 AEDT 2020


On Sun, 9 Feb 2020, Zoltan Somogyi wrote:

> 2020-02-09 16:41 GMT+11:00 Julien Fischer<jfischer at opturion.com>:
>> +This is a bug-fix release.
>> +
>> +* [Mantis bug #496]. The compiler now emits a reminder about the limitation
>> +  of common subexpression elimination in the presence of uniqueness when
>> +  this is a possible cause of determinsim errors.
>
> Determinism is spelt wrong. A full spellcheck would be in order.

Fixed.  (And done.)

>> +  As of version 20.01, common subexpression elimination does not transform
>> +
>> +         (
>> +             X = f(A1, ..., An),
>> +             goal A
>> +         ;
>> +             X = f(B1, ..., Bn),
>> +             goal B
>> +         )
>> +
>> +  into
>> +
>> +         X = f(X1, ..., Xn),
>> +         (
>> +             A1 = X1, ..., An = Xn,
>> +             goal A
>> +         ;
>> +             B1 = X1, ..., Bn = Xn,
>> +             goal B
>> +         )
>> +
>> +  when the insts of some of `X`'s arguments are at least partially unique.
>
> Why is X quoted? It interferes with the apostrophe, and so subtracts
> rather than adds clarity.

It's a inline code span in markdown; when converted to HTML X will be
in the same font as the examples above.  (In HTML it will become
<code>X</code>.)

I've chanaged it to:

     ... when the insts of some of the arguments of `X` are at least ...

Julien.


More information about the reviews mailing list