[m-rev.] for review: add a "suggested replacement" arg to obsolete pragmas

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Sep 9 13:56:40 AEST 2019



On Mon, 9 Sep 2019 13:06:21 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> >> The main change in {Log,DIFF}.obs adds the optional new argument
> >> to obsolete pragmas.
> >
> > That looks fine.

Thank you.

> >> Once that diff reaches the rotds and is installed
> >> on each of our systems, the second diff can be committed.
> >
> > I disagree with deprecating *.from_list, *.from_sorted_list list.
> >
> > Preferences aside, the naming patterns
> >
> >    <module>.to_<type>
> >    <module>.from_<type>
> >
> > and related
> >
> >    <module>.cast_to_<type>
> >    <module>.cast_from_<type>
> >
> > are widely used in the standard library compared to <type>_from_<type>
> > and <type>_to_<type>.
> 
> Seconded, do not deprecate the from_* versions.

OK, I won't mark them as obsolete. But there is a new question about
from_sorted_list: should it be a synonym for the checked or the unchecked version
of sorted_list_to_set? Either way we decide, it will surprise some users.

Zoltan.


More information about the reviews mailing list