[m-rev.] for post-commit review: add preds via item_pred_decl_infos

Julien Fischer jfischer at opturion.com
Mon Sep 2 12:21:57 AEST 2019


On Mon, 2 Sep 2019, Zoltan Somogyi wrote:

> For review by anyone.
>

> Add all predicates via item_pred_decl_infos.

...

> diff --git a/compiler/add_class.m b/compiler/add_class.m
> index aa7a2f70c..21704948e 100644
> --- a/compiler/add_class.m
> +++ b/compiler/add_class.m
> @@ -308,41 +308,33 @@ classify_class_decls([Decl | Decls], !:PredOrFuncInfos, !:ModeInfos) :-

...

>      ).
> -
> -    init_markers(Markers0),
> -    add_marker(marker_class_method, Markers0, Markers),
> -    module_add_pred_or_func(Origin, Context, ItemNumber,
> -        MaybeItemMercuryStatus, PredStatus, NeedQual,
> -        PredOrFunc, PredName, TypeVarSet, InstVarSet, ExistQVars,
> -        TypesAndModes, Constraints, MaybeDetism, Purity, Markers,
> -        MaybePredProcId, !ModuleInfo, !Specs),
> +    Attrs = item_compiler_attributes( compiler_origin_class_method),

Delete the extra space there.

Looks fine otherwise.

Julien.


More information about the reviews mailing list