[m-rev.] for post-commit review: handle all builtin types in library/term_to_xml.m

Julien Fischer jfischer at opturion.com
Wed Oct 16 21:16:02 AEDT 2019


On Wed, 16 Oct 2019, Zoltan Somogyi wrote:

> On Wed, 16 Oct 2019 17:33:41 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>> +    ;       foreign(ftype)
>> +    ;       primitives(
>> +                int, uint, int8, int16, int32, int64,
>> +                uint8, uint16, uint32, uint64).
>
> Why is the uint field not with the uintN fields?

No particular reason, I've shifted it.

> Apart from that, the diff is fine, though it would be nice if you could document
> why the LLDS and MLDS backends need different expected output files.

Done.

Julien.


More information about the reviews mailing list