[m-rev.] for review: make binary_{input, output}_stream_offset abort on overflow

Julien Fischer jfischer at opturion.com
Mon Oct 14 20:33:26 AEDT 2019


On Mon, 14 Oct 2019, Zoltan Somogyi wrote:

> On Mon, 14 Oct 2019 18:04:02 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> What I meant by "wherever possible" is exactly that we shouldn't do it
> in predicates that are not the library entry point that the user called.
> If you call predicate x, you don't expect an exception from predicate y,
> or even function x, as you say.
>
> But when the call to error is in the interface predicate or function, and that
> predicate is not in the call tree of any other interface predicate or function,
> then there is no reason not to do it.

Fair enough; I'll go through the library and change things where
possible (since I need to go and fix a bunch of spots where we are
throwing strings rather than software_errors anyway).

Julien.


More information about the reviews mailing list