[m-rev.] for review: add 64-bit versions of seek and offset on binary streams

Julien Fischer jfischer at opturion.com
Tue Oct 8 21:28:57 AEDT 2019


On Tue, 8 Oct 2019, Zoltan Somogyi wrote:

> On Tue, 8 Oct 2019 20:43:11 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>> The right thing to do is transition users to a version that always uses
>> 64-bit offsets.  All the underlying platforms provide that anyway.
>
> My email proposed such as plan. It is sort-of still valid if you replace
> the _32 suffix in names with something else that suggests pot-luck
> with platform int sizes.

What I propose to do in fairly short order is:

1. add checks to the unsuffixed version to ensure we do not exceed
32-bits where int is 32-bit.

2. mark the unsuffixed versions as obsolete.

3. document the problems with using int as an offset in the library
documentation and NEWS file.

I think that should suffice.

Julien.


More information about the reviews mailing list