[m-rev.] for review: Disable uninitialized variable warnings in high-level C grades.

Julien Fischer jfischer at opturion.com
Fri May 31 19:27:58 AEST 2019


On Fri, 31 May 2019, Peter Wang wrote:

> On Fri, 31 May 2019 17:12:47 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
>>
>> Hi Peter,
>>
>> On Fri, 31 May 2019, Peter Wang wrote:
>>
>>> scripts/mgnuc.in:
>>>    Disable uninitialized variable warnings in high-level C grades.
>>>    This is necessary but went (mostly) unnoticed because we happen to
>>>    disable uninitialized variable warnings for gcc on x86/x86_64 in
>>>    support of low-level C grades, and we suppress any and all warnings
>>>    if using clang.
>>
>> IIRC, disabling all warnings was necessary with some very early versions
>> of clang -- we should probably re-enable them at some
>> point since we no longer support those versions of clang.
>
> Yes, I sent an incomplete patch last year but then got distracted by
> trying to "fix" fields in RTTI structures from signed to unsigned types,
> which then got caught up how to deal with Java RTTI fields since Java
> doesn't have unsigned types... that was a mistake.

Trying to change the RTTI fields, Java's choice of builitn types or
both?  ;-)

The diff is fine BTW.

Julien.


More information about the reviews mailing list