[m-rev.] for review: simplify the creation of .int3 files

Julien Fischer jfischer at opturion.com
Thu Jan 31 13:07:19 AEDT 2019

Hi Zoltan,

On Tue, 29 Jan 2019, Zoltan Somogyi wrote:

> The diff is for review by Julien or Peter, but I would like everyone's
> feedback on the plans above.

I have no objections to your plan -- that said, it's been a while
since I worked on that part of the compiler so I've probably forgotten
quite a few things about it.

> To make a review easier, I am attaching the summary of how the pre-diff
> compiler computed what goes into a .int3 file. I would suggest that
> whoever does the review, do it in two stages: check whether the summary
> is a correct description of what the old code does,

The description looks correct.

> and then check whether
> what the new code does for each kind of item is what the summary calls for
> that kind of item. Otherwise, the correspondence between the too-complex
> old code and the simple new code is too hard to keep track of in one's head.
> I am also attaching the output of git diff both with and without -b.

As you wish to continue working on it, I'm happy for you to commit now.  I had
a look through you the latest version of your change and couldn't see anything
obviously incorrect.


More information about the reviews mailing list