[m-rev.] for post-commit review: implement Mantis 477
jfischer at opturion.com
Sat Apr 20 12:28:37 AEST 2019
On Sat, 20 Apr 2019, Zoltan Somogyi wrote:
> For post commit review by Julien, since it is his feature request.
> The other diff is for a couple of issues I noticed while working on 477.
> Warn about infinite recursive calls inside try goals.
> diff --git a/compiler/simplify_info.m b/compiler/simplify_info.m
> index d07d9d1..731806d 100644
> --- a/compiler/simplify_info.m
> +++ b/compiler/simplify_info.m
> @@ -52,17 +52,17 @@
> % for a switch?
> snc_inside_dupl_for_switch :: bool,
> - % Count of the number of lambdas which enclose
> - % the current goal.
> - snc_num_enclosing_lambdas :: int,
> % Can the procedure we are inside be invoked from an
> % all-solutions predicate?
> % If we are inside one or more lambda expressions,
> % the relevant procedure is the innermost lambda,
> % which will later be transformed into a separate procedure.
> % If yes, identify the procedure.
> - snc_proc_is_model_non :: maybe(innermost_proc)
> + snc_proc_is_model_non :: maybe(innermost_proc),
> + % Count of the number of lambdas which enclose
> + % the current goal.
> + snc_num_enclosing_barriers :: int
The comment there still refers to lambdas; it should explain what is meant
by a barrier.
The rest looks fine.
More information about the reviews