[m-rev.] for review: ensure signed integer arithmetic wraps on overflow in C grades

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun May 6 00:46:29 AEST 2018



On Sat, 5 May 2018 09:26:19 -0400 (EDT), Julien Fischer <jfischer at opturion.com> wrote:
> Ensure signed integer arithmetic wraps on overflow in C grades.

That's fine, with one possible minor exception.

I have always put a space after the parenthesized type name in a C cast,
but the runtime also has code that omits that space, as does this diff.
There is nothing on the subject in compiler/notes/c_coding_standard.html.
Should we add a rule about this? And if yes, which way?

Zoltan.


More information about the reviews mailing list