[m-rev.] for review: fix some comments in {int,uint}.m

Peter Wang novalazy at gmail.com
Fri Jul 13 14:37:10 AEST 2018

On Fri, 13 Jul 2018 14:30:59 +1000, Mark Brown <mark at mercurylang.org> wrote:
> Hi Adrian!
> On Fri, Jul 13, 2018 at 8:38 AM, Adrian Wong <adrianwjw at gmail.com> wrote:
> > As below. Apologies if I'm going about this review process incorrectly.
> Thanks for the change, that looks good. I've merged the pull request.
> Personally I'm happy for people to use pull requests rather than go
> via the mailing list. I can't remember if anyone else had any
> objections, though.

It makes sense for anyone without write access to the repository (yet)
to make a pull request.

BTW, I've unticked "Allow merge commits" under the project's "Merge
button" setting. Pull requests can be accepted by squashing or rebasing.
If anyway really wants merge commits for some reason we can change it
back, but I see no reason for changes accepted via pull request to
differ from changes we push directly.


More information about the reviews mailing list