[m-rev.] for review: pack small args next to local secondary tags

Julien Fischer jfischer at opturion.com
Thu Jul 12 11:45:23 AEST 2018

On Thu, 12 Jul 2018, Zoltan Somogyi wrote:

> On Tue, 3 Jul 2018 21:14:22 -0400 (EDT), Julien Fischer <jfischer at opturion.com> wrote:
>> Specifically, in asm_fast.gc.decldebug.trseg.stseg, the following
>> fail on my system (x86-64,linux):
>>     hard_coded/arith_int16
>>     hard_coded/arith_int32
>>     hard_coded/arith_int8
>>     hard_coded/pack_int32
>> The packing one is most likely failing bcause the arithmetic ones are.
>> (This looks like a regression of the issue fixed in commit b765dae,
>> but it isn't since the test case for that passes.)
> The attached diff fixes these failures.

Thanks for that!

> My decldebug bootcheck showed some new failures in place of these ones.
> The solns and sort test cases in the decldebug directory are now failing,
> due seemingly to changes in the internals of I/O operations. For the solns
> test case, the right fix is probably to use the filter that replaces numeric
> event numbers with symbols, but for the sort test case, that won't work.

I think the main issue they have is that the number of tabled I/O
operations now exceeds the default threshold for printing them out.


More information about the reviews mailing list