[m-rev.] for review: Delete redundant information in LICENSE.

Peter Wang novalazy at gmail.com
Sun Feb 25 11:48:06 AEDT 2018


On Fri, 23 Feb 2018 22:23:05 +1100 (AEDT), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> 
> On Fri, 23 Feb 2018 18:24:44 +1100, Peter Wang <novalazy at gmail.com> wrote:
> >  The subdirectory `boehm_gc' contains a slightly modified copy of version
> > -7.4.2 of the conservative garbage collector distributed by Hans Boehm:
> > +of the Boehm-Demers-Weiser Garbage Collector. See boehm_gc/README.md for
> > +copyright information.
> 
> The middle of that sentence now appears to read "slightly modified copy of version
> of the BDW ...", which is bad english. I think you need to delete "of version".

Fixed.

> > +The atomic_ops library (libatomic_ops) contains some code that
> > +is covered by the GNU General Public License, but is not needed by, nor
> > +linked into the collector library or Mercury. It is included here only
> > +because the libatomic_ops distribution is included in its entirety.
> 
> I would replace the last line with "because it is simpler to include the libatomic_ops
> distribution in its entirety".

Changed.

Peter


More information about the reviews mailing list