[m-rev.] for post-commit review: group *int_least* types together

Julien Fischer jfischer at opturion.com
Sun Feb 18 20:40:18 AEDT 2018


On Sun, 18 Feb 2018, Zoltan Somogyi wrote:

> Julien, can you please have a look at the parts of the diff
> to llds_out_global.m that are marked by XXX BUG?
> I am not sure how I can write tests for the bounds of
> {u,}int_least32 that will work on both 32 and 64 machines,
> given the current state of bootstrapping 64 bit integers.

What's the issue with the current state of 64-bit integers?  Bootstrap
compilers have been required to support them since the beginning of this
month.  (Indeed, the Mercury compiler itself has been using them since
then as well.)

The last major** uncommitted piece of work for 64-bit integers, is
enabling unboxed 64-bit integers on 64-bit machines, but that only
affect performance.  (I'll be committing the chnage that enables that

Have I missed something here?


** actually, we need to support smart indexing on all the new fixed
size integer types, as well as extend string.format to suppor them,
allow them in fact tables etc etc, so that's not entirely true.

More information about the reviews mailing list