[m-rev.] problems with abs for int{8,16,32}

Julien Fischer jfischer at opturion.com
Sat Feb 17 13:43:34 AEDT 2018



On Sat, 17 Feb 2018, Zoltan Somogyi wrote:

>
>
> On Sat, 17 Feb 2018 10:46:08 +1100 (AEDT), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>> What this means that the *proper* fix for this bug will require
>> a thorough review of the LLDS code generator's handling of argument
>> packing, which I *can't* do in a weekend. A quick fix that works
>> for this bug *only* is possible in that time, but I cannot guarantee
>> that it won't break something else.
>
> A potential quick fix is attached. Julien, please try it out and tell me
> whether it works for you.

Yes, that's fine, please go ahead and commit it.

> (It passes bootcheck in asm_fast.gc,
> and compiles your cut-down test case correctly in asm_fast.gc with -O0.)

It also passes a bootcheck asm_fast.gc at -O0.

Julien.


More information about the reviews mailing list