[m-rev.] for review: module_add_type_defn

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Jun 29 01:10:28 AEST 2017



On Wed, 28 Jun 2017 22:32:28 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> > However, the existing implementation says yes; it allows having both a
> > solver type and a foreign type definition for the same name.
> 
> My guess would be that the code for adding types was never updated
> properly when the current version of solver types was added.

That is my guess as well.

The attached diff implements what we agreed on. I am committing it;
I would appreciate it if you would look over the diffs to NEWS and to
tests/valid/solver_type_bug.m.

Zoltan.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.sns
Type: application/octet-stream
Size: 1249 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20170629/9d9e8560/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.sns
Type: application/octet-stream
Size: 17824 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20170629/9d9e8560/attachment-0003.obj>


More information about the reviews mailing list