[m-rev.] for review: document the uint type

Julien Fischer jfischer at opturion.com
Thu Jun 8 23:54:38 AEST 2017


Hi Zoltan,

On Thu, 8 Jun 2017, Zoltan Somogyi wrote:

>
>
> On Thu, 8 Jun 2017 22:07:33 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
>>   In the current implementation, @code{MR_Integer} is a typedef for a signed
>>   integral type whose size is the same size as a pointer of type @samp{void *};
>> + at code{MR_Unsigned} is a typedef for an unsigned integral type whose size is the
>> +same as a pointer of type @samp{void *};
>
> I would change the wording of both the old and new sentences to say
> "is a typedef for an signed/unsigned integral type which is the same size as ...".

Done.

> The rest of the diff is fine.

Thanks for the review.

Julien.


More information about the reviews mailing list