[m-rev.] for review: Do not opt-export `try' goals.

Peter Wang novalazy at gmail.com
Mon Sep 19 14:30:33 AEST 2016


On Mon, 19 Sep 2016 13:46:14 +1000, Paul Bone <paul at bone.id.au> wrote:
> On Mon, Sep 19, 2016 at 01:37:09PM +1000, Peter Wang wrote:
> > diff --git a/library/exception.m b/library/exception.m
> > index 2f133b9..ed99dda 100644
> > --- a/library/exception.m
> > +++ b/library/exception.m
> > @@ -616,8 +616,8 @@ unsafe_call_transaction_goal(Goal, STM0, {Result, STM}) :-
> >  
> >  %---------------------------------------------------------------------------%
> >  
> > -magic_exception_result(succeeded({})).
> > -magic_exception_result(succeeded({})).  % force cc_multi
> > +magic_exception_result(_) :-
> > +    throw("magic_exception_result called").
> >  
> >  unreachable :-
> >      throw("unreachable code reached").
> 
> Do we want a more descriptive message there?  Something that tells the user
> that it should never be called directly and/or the compiler will always
> remove it?

I've improved the message.  Thanks.

Peter


More information about the reviews mailing list