[m-rev.] for review: --warn-no-stream-calls

Julien Fischer jfischer at opturion.com
Sun Oct 16 01:02:54 AEDT 2016


On Sat, 15 Oct 2016, Zoltan Somogyi wrote:

> On Sat, 15 Oct 2016 21:37:24 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>> I suggest --warn-implicit-stream-calls as the option name.  It's really the
>> implicitness of the stream calls that is the issue.  (Also, the negated form of
>> the original name is --no-warn-no-stream-calls, which is a little unwieldy.)
>
> I agree, and made the change.
>
> The attached diff addresses both this review, and the previous one.
> It is for post commit review by Julien.

That looks fine.

Julien.


More information about the reviews mailing list