[m-rev.] for post-commit review: fix mantis bug 415

Julien Fischer jfischer at opturion.com
Wed Aug 31 14:07:55 AEST 2016


Hi,

On Tue, 30 Aug 2016, Zoltan Somogyi wrote:

> For review by anyone.

Actually, I have one suggestion here.  Since the language allows us to
omit the inst constraint when the constraint is 'ground', we should do
the same in error messages.  For example,

         bug415.m:046: In clause for `ip_chunk_2(in(list.list((I =< ground))), in,
         bug415.m:046:   in(list.list((I =< ground))), in, out(list.list((I =<
         bug415.m:046:   ground))))':
         bug415.m:046:   mode error: argument 6 became too instantiated.
         bug415.m:046:   Final instantiatedness of `HeadVar__5' was
         bug415.m:046:     bound(
         bug415.m:046:       []
         bug415.m:046:     ;
         bug415.m:046:       '[|]'(
         bug415.m:046:         ground,
         bug415.m:046:         bound(
         bug415.m:046:           []
         bug415.m:046:         ;
         bug415.m:046:           '[|]'(
         bug415.m:046:             ( I =< ground ),
         bug415.m:046:             internal $merge_inst #1,
         bug415.m:046:             which expands to
         bug415.m:046:               bound([] ; '[|]'(( I =< ground ),
         bug415.m:046:               internal $merge_inst #1))
         bug415.m:046:           )
         bug415.m:046:         )

etc etc, would become:

         bug415.m:046: In clause for `ip_chunk_2(in(list.list((I))), in,
         bug415.m:046:   in(list.list((I))), in, out(list.list((I))))':
         bug415.m:046:   mode error: argument 6 became too instantiated.
         bug415.m:046:   Final instantiatedness of `HeadVar__5' was
         bug415.m:046:     bound(
         bug415.m:046:       []
         bug415.m:046:     ;
         bug415.m:046:       '[|]'(
         bug415.m:046:         ground,
         bug415.m:046:         bound(
         bug415.m:046:           []
         bug415.m:046:         ;
         bug415.m:046:           '[|]'(
         bug415.m:046:             I,
         bug415.m:046:             internal $merge_inst #1,
         bug415.m:046:             which expands to
         bug415.m:046:               bound([] ; '[|]'((I),
         bug415.m:046:               internal $merge_inst #1))
         bug415.m:046:           )
         bug415.m:046:         )

Julien.


More information about the reviews mailing list