[m-rev.] the grade library is ready for review

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Apr 5 14:57:37 AEST 2016

On Tue, 5 Apr 2016 14:03:31 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:

> On Fri, 1 Apr 2016, Zoltan Somogyi wrote:
> > The try_all_grade_structs program is a sanity check; it tests whether
> > the grade library can properly process all valid grades (of which there
> > are more than one million!). This takes a bit less than a minute on
> > my laptop, which shows that the grade library can handle the kinds
> > of problems that this test poses in about 50 microseconds each.
> > (I expect that solving partial, not full, grade specifications takes longer.)
> The runtime says:
>   #error "Sorry, not supported: --high-level-code --gc accurate --thread-safe"
> (Which is indeed the case.)
> However, try_all_grade_structs is generating grades containing
> components that corespond to the above options, e.g. hlc.par.agc 
> and hlc_nest.par.agc.

That's because the above error is NOT from mercury_grade.h, where it
*should* be, but in mercury.h.

I will add the requirement "accurate gc requires not thread safe", and
anything else encoded in mercury.h's code. Thanks.


More information about the reviews mailing list