[m-rev.] for post-commit review: fix a perf bug

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Oct 29 14:45:23 AEDT 2015


The story of how I found the need for this fix is in the log message.

This diff  just works around the performance problem for code 
that does not use solver types. It does so by avoiding calls to
the actual problem predicate, candidate_init_vars.

That predicate was introduced into what was then modes.m in 2004,
in commit 3bbfd4c7c98ee54de9ab7a0aa2ea6ba31d0e3d9d. It was
added by rafe, so I cannot ask him, but maybe someone else has
worked on it since. Does anyone know why it is written the way it is?
If someone does, maybe we could actually solve the problem,
not just work around it.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.cand_vars
Type: application/octet-stream
Size: 2220 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20151029/2e6b26c4/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.cand_vars
Type: application/octet-stream
Size: 8815 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20151029/2e6b26c4/attachment-0001.obj>


More information about the reviews mailing list