[m-rev.] for review: replace the item list with structured ASTs

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Jul 21 02:05:02 AEST 2015

On Mon, 20 Jul 2015 09:59:53 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> >     we used to use to identify file types. Predicates that used to take strings
> >     representing suffixes as arguments now have to specify whether they can
> >     handle all these file types (source, information and optimization),
> s/information/interface/

Actually, that is just a one-character typo in my vim macros, IF vs INF :-(

> > +% combinations of answers into an enum. For the details, see status_proposal
> > +% in compiler/notes.
> There is no such file.

Git strikes again. I added it with "git add", not "git add -N", so obviously
"git diff" didn't show it :-(

> > +:- pred sym_name_get_module_name_det(sym_name::in, module_name::out) is det.
> > +
> The usual convention for naming such predicates is to use "det_" as a prefix,
> rather than "_det" as a suffix.

I followed this suggestion, as well as all your other suggestions.

I am doing a final round of bootchecks, and will then commit the diff. I will
address anybody else's reviews after the commit.


More information about the reviews mailing list