[m-rev.] minor style update, and news about item lists

Julien Fischer jfischer at opturion.com
Sun Jul 12 20:46:30 AEST 2015


Hi Zoltan,

On Sat, 11 Jul 2015, Zoltan Somogyi wrote:

> The attached diff is a minor cleanup.
>
> I am just finishing up the change that replaces the item list with five separate
> purpose-specific structured parse trees. It bootstraps the compiler, and passes
> almost all tests, the exceptions being some tests of recompilation, hence the
> cleanup of this testing code.
>
> The coming diff will enable the compiler to generate messages for
> deviations from the expected program structure, such as :- module
> declarations being followed immediately by e.g. type or pred
> declarations, without a module marker such as :- interface or :-
> implementation. My current draft diff generates an error message for
> such cases. However, the current compiler accepts such code without
> complaint, so the difference in behavior is significant. The error is
> trivial for users to fix, so I think this change in behavior is
> acceptable, but others may prefer that it should be just a warning.
> Any opinions?

It should be an error.

> And does anyone volunteer to review the upcoming diff? It is about 22,000 lines
> right now.

I will review it.  Given the scale of the change other eyes would
be welcome as well.

Cheers,
Julien.



More information about the reviews mailing list