[m-rev.] for review: flattening the test dirs

Julien Fischer jfischer at opturion.com
Mon Feb 9 10:34:41 AEDT 2015


Hi Zoltan,

On Fri, 6 Feb 2015, Zoltan Somogyi wrote:

> We discussed this recently, and there were no objections
> in principle.
>
> The diff is in two parts. The renames are in DIFF.test_dirs_flatten,
> and the substantive changes are in the DIFF.test_dirs_after_flatten.

The change looks fine.

> I am doing some final bootchecks now. BTW, I tried to test
> how the changes cope with a workspace compiled with
> MCFLAGS += --use-subdirs, and found that if that setting
> is in my Mmake.params, and I do an "mmake" immediately
> after a mmake clean, aclocal -I m4, autoconf, and configure,
> the "mmake" fails. Anyone have an idea why that is?

Presumably, this is just plain old mmake, not mmake --use-mmc-make?

Cheers,
Julien.



More information about the reviews mailing list