[m-rev.] for possible post-commit review: improve module_qual.m

Julien Fischer jfischer at opturion.com
Wed Aug 12 21:17:31 AEST 2015


Hi Zoltan,

On Wed, 12 Aug 2015, Zoltan Somogyi wrote:

> The changed to the code are minor; the important part
> of the diff is the rewrite of the big initial comment.

Looks fine, except for:

> diff --git a/compiler/module_qual.m b/compiler/module_qual.m
> index 1444299..52348b5 100644
> --- a/compiler/module_qual.m
> +++ b/compiler/module_qual.m
> @@ -9,15 +9,54 @@
>  % File: module_qual.m.
>  % Main authors: stayl, fjh.
>  %
> -% Module qualifies types, insts and modes within declaration items.
> -% The head of all declarations should be module qualified in prog_io.m.
> -% This module qualifies the bodies of the declarations. Checks for
> -% undefined types, insts and modes. Uses two passes over the item list,
> -% one to collect all type, mode and inst ids and a second to do the
> -% qualification and report errors. If the --warn-interface-imports
> -% option is set, warns about modules imported in the interface that do
> -% not need to be in the interface. The modes of lambda expressions are
> -% qualified in modes.m.
> +% The code in this module performs two tasks.
> +%
> +% - It checks for undefined types, typeclasses, insts and modes.
> +%
> +% - It module qualifies types, typeclasses, insts and modes within declaration
> +%   items in the source code of the compilation unit. The heads of all
> +%   declarations should be module qualified as they are read in in prog_io.m;

s/in in/in by/

Cheers,
Julien.



More information about the reviews mailing list