[m-rev.] for review: tighten up checks for invlaid grade in mgnuc script etc

Peter Wang novalazy at gmail.com
Thu Apr 23 10:11:20 AEST 2015


On Wed, 22 Apr 2015 15:30:03 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> 
> Hi,
> 
> On Wed, 22 Apr 2015, Peter Wang wrote:
> 
> > On Wed, 22 Apr 2015 11:26:35 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> >> +
> >> +#
> >> +# .profdeep grades are not compatible with high-level code
> >> +#
> >> +case $highlevel_code,$profile_deep in true,true)
> >> +	echo "--high-level-code and --profile-deep are not compatible" 1>&2
> >> +	exit 1 ;;
> >> +esac
> >
> > --deep-profiling
> 
> Fixed.  Actually, --deep-profiling is what mmc uses, --profile-deep is
> what the mgnuc script uses :-(
> 
> The mgnuc script (and canonical_grade etc) could do with further
> clean-ups if anyone is interested in taking a look at it.  In
> particular, they should really reject an attempt to specify two base
> grades, for example "csharp.erlang".

Hardly anyone would be using those scripts any more, would they?

I think we can reduce confusion by moving the documentation for mmake
and its helpers out of the user guide and into a separate document;
and, to a lesser degree, moving the helper scripts out of the main bin
directory and into lib/mercury/bin or something.

Peter



More information about the reviews mailing list