[m-rev.] for review: generate executables in the Java grade as JARs
paul at bone.id.au
Fri Apr 17 00:14:29 AEST 2015
On Thu, Apr 16, 2015 at 11:35:54PM +1000, Julien Fischer wrote:
> Hi Paul,
> On Thu, Apr 16, 2015 at 11:26 PM, Paul Bone <paul at bone.id.au> wrote:
> > On Tue, Apr 07, 2015 at 12:18:13PM +1000, Julien Fischer wrote:
> > >
> > > compiler/compile_target_code.m:
> > > Rename the link target type for Java executables.
> > >
> > > Add a predicate for creating Java "executables": this involves
> > generating
> > > an archive (as we do for libraries) and then generating the
> > wrapper script
> > > or batch file.
> > There are a number of overlong lines in this patch.
> > You'll need to check the whole patch.
> Ok, done.
> > The semantics look fine.
> > I think it would also be useful to generate .jar files for libraries. That
> > can be a later patch that hopefully re-uses some of this work.
> I'm not sure what you mean. We already do generate .jar files for libraries
> and have done so for years.
Okay, I didn't know that. I was making an assumption.
More information about the reviews