[m-rev.] for review: record the git revision the Mercury compiler was compiled with

Paul Bone paul at bone.id.au
Thu Apr 16 23:18:45 AEST 2015


On Sat, Apr 04, 2015 at 01:24:57PM +0800, Sebastian Godelet wrote:
> Hi,
>
> I think this functionality would be nice to have as I've seen it
> already in some other tools which are configured and build from git  
> repositories.
>
> Sebastian.
>

Thanks for contributing this, I've wanted this feature myself for some time.

The patch itself looks fine.  My question is how will this behave when
someone builds the source distribution?

Perhaps a better solution is to set the git revision at the time the source
distribution was created, and have configure use that when it is invoked as
part of the source distribution.  Are you up for implementing/testing this?

Cheers.


-- 
Paul Bone



More information about the reviews mailing list