[m-rev.] for review: rewrite of vim syntax file

Peter Wang novalazy at gmail.com
Wed Apr 15 12:00:06 AEST 2015

On Tue, 14 Apr 2015 15:26:09 +0800, Sebastian Godelet <sebastian.godelet at outlook.com> wrote:
> Would you mind rebasing your diff to the current master (that one has 
> the colouring for head clauses already addressed) if possible?
> If that's not possible, then I'll do it by hand.

It's here: https://github.com/wangp/mercury-experimental/tree/vim

> In your diff, you marked these <Fx> keyboard commands as conflicting:
>     " <F6> attempts to wrap a call up with { } braces for DCG escapes.
>     "
> -nnoremap <F6> I{ <ESC>%a }<ESC>j
> +" pw - conflicts
> +" nnoremap <F6> I{ <ESC>%a }<ESC>j

Sorry, it only conflicts with my own <F6> binding.

>     " <F7> and <F8> comment and uncomment lines out respectively.
>     "
> -nnoremap <F7> 0i% <ESC>j
> -nnoremap <F8> :s/% //e<CR>j
> +" pw - should only be applicable to mercury
> +" nnoremap <F7> 0i% <ESC>j
> +" nnoremap <F8> :s/% //e<CR>j
> These I didn't touch (at least I can't recall that), as far as I 
> remember there were like this in the original version.

Never mind, I just use something else for toggling comments which works
for multiple languages.

> Also about the comment line length, I just adjusted the line length to 
> the one in the standard library, e.g. from io.m (77):
> %---------------------------------------------------------------------------%
> Before it was 80 chars but I remember that I once read on the mailing 
> list that this was deemed to long once.
> Maybe I just miscount. Hope you can clarify on this.

I see, the old plugin had it at 80 chars but I had modified my copy ages
ago to 79 chars.  Now some files are moving to 77 chars.  Fine.


More information about the reviews mailing list