[m-rev.] for review: rewrite of vim syntax file

Peter Wang novalazy at gmail.com
Tue Apr 14 14:52:10 AEST 2015

On Sat, 4 Apr 2015 12:52:05 +0800, Sebastian Godelet <sebastian.godelet at outlook.com> wrote:
> Hi,
> after trying to improve some aspects of the existing Vim
> syntax file provided in the Mercury distribution,
> I came to the conclusion that it might be better to do a rewrite
> which tries to be as backwards compatible as possible while still
> allowing to add features to both the syntax file and the Vim
> plugin script.
> Do to the size of the diff I attached it rather than inlining it into 
> the email.


I like that foreign code is no longer a sea of purple or cyan.

Some of the changes are too much for me, so I customised it to look
closer to what I had before.  I attached a diff in case any of it is
useful for the official version.  (The colours are subjective but I like
to reserve yellow for declarations and clause heads to stand out.)

Other suggestions:

  - make the variable matching optional, preferably off by default as I
    find it distracting

  - move more stuff into mercury_highlight_comment_special

  - don't enable folding by default

  - don't conceal by default.  The symbols are not standard Mercury and
    may confuse.  They also look bad in some fonts.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vim.diff
Type: text/x-diff
Size: 16309 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20150414/6fe986c0/attachment.diff>

More information about the reviews mailing list