[m-rev.] for post-commit review: fix mantis bug 361

Julien Fischer jfischer at opturion.com
Thu Sep 18 11:26:23 AEST 2014


On Thu, 18 Sep 2014, Peter Wang wrote:

> On Thu, 18 Sep 2014 03:27:31 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
>>
>> On Wed, 17 Sep 2014, Zoltan Somogyi wrote:
>>
>>>> For example:
>>>>
>>>>     --add-grade-component-debug
>>>>     --add-grade-component-decldebug
>>>>     --add-grade-component-parallelism
>>>>     etc
>>>
>>> I think the name of the grade component should be accepted
>>> both when spelled out in full (e.g. parallelism) and when abbreviated
>>> (e.g. par).
>>
>> Also fine by me.
>
> How about --grade-component <option> where <option> is just a component
> of the full grade string?

I like having the word "add" there as well since it conveys the sense
that these options are cumulative.  The reason I chose individual
options is to restrict which grade components can be specifed this way.
It seems a bit pointless to allow for example "--grade-component java"
when that's already controlled by "--target java", although I guess
I have no strong objections to allowing the former as a synonym for
the latter.

> Does anyone really use --debug --trailing etc?

For what they are meant to be used for?  Probably not, that's
essentially the issue we are discussing here.  (Personally, I specify
grades directly using --grade when building executables and use
--libgrades-{include,exclude}-component to control what library grades
are installed.)

Cheers,
Julien.



More information about the reviews mailing list