[m-rev.] for review: report errors for bad ":- end_module" declarations

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Sep 1 11:45:39 AEST 2014


For review by anyone. Note that before commit, I intend to add
a more extensive test case (or several) to test each of the problems
with :- module and :- end_module declarations that the newly added
code tests for.

After this diff, I also intend to break up two modules. I intend to move
the functionality operating on sym_names out of mdbcomp/prim_data.m,
since it does not fit with the rest of that module, and I intend to move
parse_item and its call tree out of prog_io.m, leaving prog_io.m dealing
only with the top level handling of modules. Both of these should
improve cohesion, and the latter should also avoid a circular import
between prog_io and prog_io_typeclass. Are there any objections?

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.end_module
Type: application/octet-stream
Size: 2397 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20140901/4f372cd7/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.end_module
Type: application/octet-stream
Size: 41935 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20140901/4f372cd7/attachment-0001.obj>


More information about the reviews mailing list