[m-rev.] for review: Fix resource leaks in dir fold predicates.

Peter Wang novalazy at gmail.com
Tue May 13 15:00:48 AEST 2014


On Tue, 13 May 2014 14:09:09 +1000, Paul Bone <paul at bone.id.au> wrote:
> On Mon, May 12, 2014 at 04:38:26PM +1000, Peter Wang wrote:
> > The directory stream was not closed if dir.open succeeded in opening
> > the directory, but failing to read the first entry (which may be as
> > simple as an empty directory).
> > 
> > The directory stream was also not closed when dir.foldl2_process_dir2
> > returns an error value.
> > 
> 
> This looks fine to me.
> 
> It should probably also go on the version-14.01-branch with a breif note in
> the NEWS file.

The expected output might be useful, too.

Peter



More information about the reviews mailing list