[m-rev.] for review: Add foreign include files to makefile dependencies files.

Julien Fischer jfischer at opturion.com
Mon Mar 17 11:48:35 AEDT 2014


On Fri, 14 Mar 2014, Peter Wang wrote:

> List files included by pragma foreign_decl and pragma foreign_code
> declarations in the makefile dependencies file (`.d') generated for
> a module.
>
> The written dependencies are more conservative than necessary
> (e.g. C target files should not depend on Java include files),
> but I don't think any more effort is warranted.

Neither do I.

> compiler/module_imports.m:
> 	Add get_foreign_include_files to return a list of include files
> 	from a list of items.
>
> compiler/modules.m:
> 	Add foreign include files when initialising the module_imports
> 	structure in grab_imported_modules. Otherwise it will be empty
> 	when the `.d' file is automatically generated as a side-effect
> 	of generating target code.
>
> compiler/write_deps_file.m:
> 	Write include files from the module_imports structure into the
> 	`.d' file.
>
> doc/reference_manual.texi:
> 	Update manual.
>
> tests/invalid/Mmakefile:
> 	Make `missing_file' a phony target.  This change makes `make'
> 	aware of the dependency and report the error, instead of
> 	running the test case that checks the compiler's reaction
> 	to the missing file.

That looks fine.

Cheers,
Julien.



More information about the reviews mailing list