[m-rev.] for review: Print version information on two lines.

Peter Wang novalazy at gmail.com
Tue Mar 11 11:40:06 AEDT 2014


On Thu, 6 Mar 2014 10:57:05 +1100, Paul Bone <paul at bone.id.au> wrote:
> 
> Okay,
> 
> I think this is reasonable, and I'm not sure which 'looks better' so if you
> think this looks better I'm happy to go with that.  I also want to change
> the word "for" to "on"
> 
>     Mercury Compiler, version rotd-2013-10-01, on x86_64-unknown-linux-gnu

Hi Paul,

I noticed some syntax errors.

 :- pragma foreign_proc("C#",
 -    library.version(Version::out),
 +    library.version(Version::out, Fullarch::out),
      [will_not_call_mercury, promise_pure],
  "
 -    Version = runtime.Constants.MR_VERSION + "" configured for ""
 -        + runtime.Constants.MR_FULLARCH;
 +    Version = runtime.Constants.MR_VERSIONi;
 +    Fullarch = runtime.Constants.MR_FULLARCH;
  ").

MR_VERSIONi

 :- pragma foreign_proc("Erlang",
 -    library.version(Version::out),
 +    library.version(Version::out, Fullarch::out),
      [will_not_call_mercury, promise_pure, thread_safe],
  "
 -    Version = << ?MR_VERSION "" configured for "" ?MR_FULLARCH >>
 +    Version = MR_VERSION
 +    Fullarch = MR_FULLARCH
  ").

?s and ,

Peter



More information about the reviews mailing list