[m-rev.] for review: Add support for weak pointers to the C RTS

Paul Bone paul at bone.id.au
Fri Jul 18 16:21:27 AEST 2014

On Fri, Jul 18, 2014 at 03:30:37PM +1000, Julien Fischer wrote:
> Hi,
> On Fri, 18 Jul 2014, Paul Bone wrote:
>> On Tue, Apr 15, 2014 at 10:20:01PM +1000, Paul Bone wrote:
>>> For review by anyone.
>> No-one has reviewed these changes in the last three months so I've committed
>> them:
>> + Make version_array's rewind code use constant stack space.
>> + Add missing MR_GC_malloc_atomic procedure
>> + Add support for weak pointers to the C RTS
> It would have been preferable to have posted a reminder mail about
> them requiring a review than just committing them.  Are these
> changes necessary for the 14.01 branch?  I ask, because I had almost
> finished testing the current 14.01.1-beta on Windows (in all the various
> combination of build environment / C compilers) and this means I will
> have to do so all over again.

Not necessary but desirable.  They improve things for ODASE.  You're welcome
to do a post-commit review.  Also, when did we 'freeze'
version-14_01-branch?  I didn't know that you were nearly ready to release.


Paul Bone

More information about the reviews mailing list