[m-rev.] for review: fix build problems with Visual Studio 2013

Paul Bone paul at bone.id.au
Tue Jan 28 15:53:57 AEDT 2014

On Tue, Jan 28, 2014 at 03:43:50PM +1100, Julien Fischer wrote:
>>> +
>>> +
>>> +The Makefile for the Boehm garbage collector requires the files NtWin32.Mak and
>>> +Win32.Mak to be present in the build environment.  These files are *not*
>>> +included with Visual Studio 2013 and must be copied or included from the
>>> +Windows 7 (or 7.1) SDK.
>>> +
>> is 7.x sufficient?
> There are only 7.0 and 7.1.  (Given that Windows has changed version
> now, there are unlikely to be any more versions of the Windows 7 SDK.)


>>> +To include the above files, append the SDK directory to the end of the INCLUDE
>>> +environment variable, for example (with the Windows 7.1 SDK):
>>> +
>>> +   C:\> set INCLUDE=%INCLUDE%;C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1a\Include
>>> +
>> is that line too long?  Is it possible to break up a line on the windows
>> shell by using a backslash?
> In the Windows command interpreter you have to use '^' to do that.
> In this case, given that the path contains significant whitespace and
> other special characters, I think it's clearer and less error prone to
> keep it all on a single line.

In that case I agree.

>>> +  If you *really* want to enable support for C level debugging, then enable the
>>> +  commented out definition of DEBUG_OPTS in scripts/mgnuc.in (in the "cl" case)
>>> +  and also enable the commented out definition of CFLAGS_FOR_DEBUG in
>>> +  configure.ac (in the "msvc*" case).
>>> +
>> Will the readers know that they may need to run autoconf, configure and
>> rebuild Mercury after these steps?
> I've added a line saying that this needs to be done and pointing the
> reader to the instructions in INSTALL.git that describe how to do that.

Good idea.

Okay, that all looks good to me.

Paul Bone

More information about the reviews mailing list