[m-rev.] diff: workaround bug #304

Paul Bone paul at bone.id.au
Tue Jan 14 16:13:12 AEDT 2014

On Tue, Jan 14, 2014 at 03:44:37PM +1100, Julien Fischer wrote:
> Branches: master, 14.01
> ----------------------
> Workaround bug #304.
> configure.ac:
> 	When using non-local gotos force GCC 4.8 to emit error messages
> 	in a format that mfiltercc can handle.

I've noticed that there are two different styles of doing this kind of
thing, and we use both.  This may be another opportunity to standardise or
at least discuss which style is preferred:

    A: As you've done here, check a compiler's version number and if high
       it "matches" then pass some options.

    B) Test is the compiler supports the options, and pass them if it does.

I'd suggest that we use B in this kind of case where all compilers
supporting these options are likely to have the same problem (due to the new

Where a compiler starts incorrectly compiling something and we need to
disable some optimisation (and that optimisation has existed in other
versions of the compiler, or is -O0) then we should use style A.

Paul Bone

More information about the reviews mailing list