[m-rev.] for review: Add integer multiplication based on Karatsuba's algorithm

Paul Bone paul at bone.id.au
Fri Feb 21 17:20:58 AEDT 2014


On Fri, Feb 21, 2014 at 04:43:17PM +1100, Julien Fischer wrote:
>
> Hi,
>
> On Tue, 11 Feb 2014, Paul Bone wrote:
>
>> From: Matthias G├╝demann <matthias.guedemann at googlemail.com>
>>
>> This patch is contributed by Matthias Guedemann as pull request #13.
>>
>> For review by Julien, he understands arbitrary precision arithmetic better
>> than I do and has offered to take a look.  I intend to take a look at the
>> parallelisation and possibly tweek it.
>
> Paul: I assume you won't look at the parallelisation stuff until after it is
> committed?
>
> The comments below apply mainly to whoever is handling this change from
> now on.  (I'm happy to deal with the pull request and make the changes
> below if that's the easiest thing to do.)

I think I already have a workspace for it so I can do it.

I can test the parallelism at the same time.

Matthias, if you have any tests that you used to develop this I can add them
to the test case.

Thanks.


-- 
Paul Bone



More information about the reviews mailing list