[m-rev.] for review: Update reviews document

Paul Bone paul at bone.id.au
Thu Feb 13 10:46:33 AEDT 2014


On Wed, Feb 12, 2014 at 05:30:14PM +1100, Julien Fischer wrote:
>> 	    appended verbatim to the end of the diff, with descriptions
>> 	    indicating the name of the file.
>> -<li>  Write log message for this change - use template (see below).
>> <li>  Review diff and log message yourself. (see below)
>> -<li>  Send to mercury-reviews at cs.mu.oz.au, with the subject
>> -	    "for review: <short description of change>".
>> -	    Nominate a reviewer at top of diff (see below).
>> +<li>  Submit the pull request or mail the changes to us at
>> +      <a href="mailto:Mercury Reviews <reviews at lists.mercurylang.org>">
>> +       Mercury Reviews <reviews at lists.mercurylang.org></a>
>
> While I don't wish to discourage (potential) contributers, my preference
> is to use the mailing list.  Maybe, this should mention that is the
> preferred way of submitting changes.
> (Is it possible for github to automagically post pull requests to the
> reviews list?)

We allow people to submit bugs in various different ways in order to lower
barriers to participation.  I think the same should be true for patches,
with the difference that we may edit patches before committing them as we've
done with some contributions already.

Yes, that is possible, it takes a bit of scripting though.  Various event
types can be selected including edits to github's issue tracker.  Pushes to
repositories can also be captured, so we could automate mailing of diffs and
trivial diffs when reviews aren't necessary.  (I don't know if this is good
or bad, I haven't thought about it.)

Thanks.


-- 
Paul Bone



More information about the reviews mailing list