[m-rev.] for review: priority search queue ADT

Matthias Güdemann matthias.guedemann at googlemail.com
Mon Dec 1 23:30:31 AEDT 2014


Hi,

here is a version with the renaming done according to your
suggestions, including the export of the singleton/2 predicate.
I aso added a small program for tests, yet I do not know how to
integrate these tests into the Mercury test suite. Maybe you can point
me to the documentation how to do this.

I also have a version with many type_spec pragmas (for both P=int and
(P=int, K = int)). In my opinion, this could limit a lot the usage of
builtin compare and reduce the execution time. What is yur opinion
about that?

best regards
Matthias


On Thu, Nov 27, 2014 at 10:15 AM, Paul Bone <paul at bone.id.au> wrote:
> On Thu, Nov 27, 2014 at 07:52:23PM +1100, Julien Fischer wrote:
>> Hi
>>
>> On Thu, Nov 27, 2014 at 7:49 PM, Zoltan Somogyi <zoltan.somogyi at runbox.com>
>> wrote:
>>
>> >
>> >
>> > On Thu, 27 Nov 2014 09:03:00 +0100, Matthias Guedemann <
>> > matthias at guedemann.org> wrote:
>> > > in my opinion, Julien's proposal to use 'remove_min' is a good idea.
>> >
>> > Minor nit: shouldn't that be remove_least, since the (several) library
>> > modules that implement sets use that name?
>> >
>>
>> Yes, you're right it should be remove_least.
>>
>
> Thanks everyone.  I'm happy with that solution.
>
> --
> Paul Bone
-------------- next part --------------
A non-text attachment was scrubbed...
Name: psqueue.m
Type: application/octet-stream
Size: 28359 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20141201/9e7ec870/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: psqueue_test.m
Type: application/octet-stream
Size: 2785 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20141201/9e7ec870/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: psqueue_type_specs.m
Type: application/octet-stream
Size: 30054 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20141201/9e7ec870/attachment-0002.obj>


More information about the reviews mailing list